Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worked example: multiple tags #26

Merged
merged 4 commits into from Jan 19, 2022
Merged

Worked example: multiple tags #26

merged 4 commits into from Jan 19, 2022

Conversation

yolile
Copy link
Member

@yolile yolile commented Jan 18, 2022

closes #25

@yolile
Copy link
Member Author

yolile commented Jan 18, 2022

A test is failing but I think that is for a non-related feature?

@jpmckinney
Copy link
Member

I can't reproduce locally. I'm re-running all jobs.

@yolile
Copy link
Member Author

yolile commented Jan 18, 2022

I was able to reproduce the error locally, so I made a commit to fix it 32d044a. Now the error is not happening locally anymore but they are still here 🤷🏻‍♀️

@jpmckinney
Copy link
Member

jpmckinney commented Jan 18, 2022 •
edited

I think you were only able to reproduce because the nonreadable files were maybe left over on disk / not cleaned up by the test / not set up by the test correctly. The test's expectations are correct.

@jpmckinney
Copy link
Member

I removed the commit and made a new commit to help with debugging CI (for whatever reason pytest -vv isn't printing the full warnings message)

@jpmckinney
Copy link
Member

The test was expecting WARNING but now the result is ERROR. I'll check which versions of Sphinx, etc. are installed in CI.

@jpmckinney
Copy link
Member

Yes, Sphinx 4.4 uses ERROR. Apparently this was a bug: https://www.sphinx-doc.org/en/master/changes.html#id45 sphinx-doc/sphinx#9979

jpmckinney
jpmckinney approved these changes Jan 18, 2022
View reviewed changes
docs/index.rst Outdated Show resolved Hide resolved
@yolile yolile merged commit 721cd89 into main Jan 19, 2022
@yolile yolile deleted the 25-workedexmple-multiple-tags branch January 19, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change workedexample directive to support multiple tags
2 participants
@yolile @jpmckinney