ci: various fixes for linting (#81)

* style: import dd-trace hook before use in _autoload.php Signed-off-by: Tom Carrio <tom@carrio.dev> * style: import before use in otel _autoload.php Signed-off-by: Tom Carrio <tom@carrio.dev> * refactor: support logger in SplitProvider Signed-off-by: Tom Carrio <tom@carrio.dev> * test: return using stringable magic method FlagdProviderTest.php Signed-off-by: Tom Carrio <tom@carrio.dev> --------- Signed-off-by: Tom Carrio <tom@carrio.dev>
open-feature · May 20, 2023 · 3727b13 · 3727b13
1 parent bb18c04
commit 3727b13
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/hooks/DDTrace/src/_autoload.php b/hooks/DDTrace/src/_autoload.php
@@ -2,5 +2,7 @@
 
 declare(strict_types=1);
 
+use OpenFeature\Hooks\DDTrace\DDTraceHook;
+
 // automatically registers the DDTraceHook for OpenFeature
-OpenFeature\Hooks\DDTrace\DDTraceHook::register();
+DDTraceHook::register();
diff --git a/hooks/OpenTelemetry/src/_autoload.php b/hooks/OpenTelemetry/src/_autoload.php
@@ -2,5 +2,7 @@
 
 declare(strict_types=1);
 
+use OpenFeature\Hooks\OpenTelemetry\OpenTelemetryHook;
+
 // automatically registers the OTel hook for OpenFeature
-OpenFeature\Hooks\OpenTelemetry\OpenTelemetryHook::register();
+OpenTelemetryHook::register();
diff --git a/providers/Flagd/tests/unit/FlagdProviderTest.php b/providers/Flagd/tests/unit/FlagdProviderTest.php
@@ -57,7 +57,7 @@ public function testCanInstantiateHttpWithConfigObject(): void
         $mockStreamFactory->shouldReceive('createStream')->andReturn($mockStream);
 
         $mockResponse = $this->mockery(ResponseInterface::class);
-        $mockResponse->shouldReceive('getBody')->andReturn("{
+        $mockResponse->shouldReceive('getBody->__toString')->andReturn("{
             \"value\":\"{$expectedValue}\",
             \"variant\":\"{$expectedVariant}\",
             \"reason\":\"{$expectedReason}\"
@@ -111,7 +111,7 @@ public function testCanInstantiateHttpWithConfigArray(): void
         $mockStreamFactory->shouldReceive('createStream')->andReturn($mockStream);
 
         $mockResponse = $this->mockery(ResponseInterface::class);
-        $mockResponse->shouldReceive('getBody')->andReturn("{
+        $mockResponse->shouldReceive('getBody->__toString')->andReturn("{
             \"value\":\"{$expectedValue}\",
             \"variant\":\"{$expectedVariant}\",
             \"reason\":\"{$expectedReason}\"

diff --git a/providers/Split/src/SplitProvider.php b/providers/Split/src/SplitProvider.php
@@ -70,7 +70,7 @@ public function __construct(?string $apiKey = '', array $options = [])
         $this->client = $factory->client();
     }
 
-    public function setLogger(LoggerInterface $logger)
+    public function setLogger(LoggerInterface $logger): void
     {
         Di::setLogger($logger);
     }