Upgrade to latest Storybook #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
- Coverage 69.64% 63.82% -5.82%
==========================================
Files 207 93 -114
Lines 4335 1642 -2693
Branches 1155 427 -728
==========================================
- Hits 3019 1048 -1971
+ Misses 1316 594 -722 ☔ View full report in Codecov by Sentry. |
sergei-maertens
force-pushed
the
chore/662-sb-upgrade
branch
from
6eb208c
to
df6bbe4
Compare
Automigrator detects if it's set, not just its value.
* TODO: check dependencies for issues * TODO: check implicit spies migration
* Handle the v1 -> v2 breaking change update * Handle the project/package rename to be SB8 compatible
* Mocks/spies must now be specified explicitly * Fixed some minor console warnings/errors
Couldn't figure out why it was used.
The testing-library/user-event library upgrade broke the file uploads.
sergei-maertens
force-pushed
the
chore/662-sb-upgrade
branch
from
afa08b7
to
758b1a9
Compare
sergei-maertens
force-pushed
the
chore/662-sb-upgrade
branch
2 times, most recently
from
a554be6
to
ec7dfdb
Compare
sergei-maertens
force-pushed
the
chore/662-sb-upgrade
branch
from
ec7dfdb
to
5105154
Compare
In hopes this fixes test flakiness...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #662
Locally running storybook in dev mode and then running tests with
npm run test:storybookis flaky, see storybookjs/test-runner#442, but this doesn't appear to be an issue with a production build.