Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming from server to event #231

Closed
wants to merge 3 commits into from
Closed

Conversation

zeeliu7
Copy link
Contributor

@zeeliu7 zeeliu7 commented Apr 23, 2024

Renaming from server to event, including all files inside src/worker/event and src/common/config.go and scripts/sock_test.py.
Kafka code coming later this week.

@tylerharter
Copy link
Member

I don't think we want to rename server to event in so many places in the code (a lot of the things you renamed are genuinely servers). I was just imagining you would rename the directory, and the go package name. Servers are one of the things that should be in the event package.

There's some commented out code here related to Kafka too -- that shouldn't be part of it.

@zeeliu7
Copy link
Contributor Author

zeeliu7 commented May 22, 2024 via email

@zeeliu7 zeeliu7 closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants