-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16235: need quote fullyQualifiedName in Ingestion Framework #16273
Conversation
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Thanks for the PR @juntaozhang. @TeddyCr will get back here |
ingestion/src/metadata/data_insight/processor/reports/web_analytic_report_data_processor.py
Outdated
Show resolved
Hide resolved
ingestion/src/metadata/data_insight/processor/reports/web_analytic_report_data_processor.py
Outdated
Show resolved
Hide resolved
ingestion/src/metadata/data_insight/processor/reports/web_analytic_report_data_processor.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @juntaozhang. Left one comment.
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Describe your changes:
Fixes #16235
def get_latest_table_profile
, the arg ofquote
about safe should remove/
web_analytic_report_data_processor.py
,entity_href
parse needquote
full url because of special characters likedim(shop)
Type of change:
Checklist:
Fixes #16235: need quote fullyQualifiedName in Ingestion Framework