Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: trino integration test #16291

Merged
merged 21 commits into from
May 22, 2024
Merged

MINOR: trino integration test #16291

merged 21 commits into from
May 22, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented May 15, 2024

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner May 15, 2024 20:15
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels May 15, 2024
@sushi30 sushi30 added testing and removed testing labels May 15, 2024
- removed "helpers" as its being used
pmbrull
pmbrull previously approved these changes May 16, 2024
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Copy link

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@@ -324,6 +324,7 @@
"minio==7.2.5",
*plugins["mlflow"],
*plugins["datalake-s3"],
"requests==2.31.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the pinning on base and kept this one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah fair enough

Copy link

sonarcloud bot commented May 22, 2024

@sushi30 sushi30 enabled auto-merge (squash) May 22, 2024 15:02
@sushi30 sushi30 requested a review from pmbrull May 22, 2024 15:03
@@ -324,6 +324,7 @@
"minio==7.2.5",
*plugins["mlflow"],
*plugins["datalake-s3"],
"requests==2.31.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah fair enough

@sushi30 sushi30 merged commit d5bf30c into main May 22, 2024
11 checks passed
@sushi30 sushi30 deleted the trino-integration-test branch May 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants