compile: bundle roots can be provided by caller #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaj
force-pushed
the
compile-with-roots
branch
from
2e7dcb8
to
7a7304f
Compare
compile/compile.go
Outdated
| @@ -223,6 +224,12 @@ func (c *Compiler) WithMetadata(metadata *map[string]interface{}) *Compiler { | |||
| return c | |||
| } | |||
|
|
|||
| // WithRoots sets bundle roots in the .manifest | |||
There was a problem hiding this comment.
Nit: Can we update the description to something like WithRoots sets the roots to include in the output bundle manifest.
There was a problem hiding this comment.
Thanks for the comment. Updated.
kubaj
force-pushed
the
compile-with-roots
branch
from
7a7304f
to
32a2474
Compare
Previously, bundle roots couldn't be provided and neither .manifest file couldn't be provided, because it was replaced by the .manifest generated by the compiler. Fixes: open-policy-agent#6085 Signed-off-by: Jakub Kulich <jakubkulich@gmail.com>
ashutosh-narkar
force-pushed
the
compile-with-roots
branch
from
32a2474
to
6b680fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
Previously, bundle roots couldn't be provided and neither .manifest file couldn't be provided, because it was replaced by the .manifest generated by the compiler. This will help to build bundles from using the Go library for more advanced use cases with multiple bundles.
What are the changes in this PR?
Added
WithRootsoption so caller can provide roots.Notes to assist PR review:
Further comments:
Fixes: #6085