Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pipette as AdditionDevice option #708

Open
connorcoley opened this issue Jan 18, 2024 · 3 comments
Open

Add Pipette as AdditionDevice option #708

connorcoley opened this issue Jan 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@connorcoley
Copy link
Collaborator

No description provided.

@connorcoley connorcoley added the enhancement New feature or request label Jan 18, 2024
@bdeadman
Copy link
Collaborator

bdeadman commented Feb 6, 2024

Agree that Pipette will be a good AdditionDeviceType option to have.

Enum option has been added into bdeadman/ord-schema:schema_added_enums but I will have a think about other addition device options that synthesis chemists may need before making the pull request. The immediate gap that comes to mind is pump(s) but I know these are also defined under FlowConditions so there may be good reasons not to allow a pump enum under input AdditionDeviceType.

@bdeadman
Copy link
Collaborator

Issue #607 can also be addressed at the same time.

@bdeadman
Copy link
Collaborator

bdeadman commented May 2, 2024

Pull request #718 will add pipette, and positive displacement pipette as options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants