Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some addition device types, and analysis types. #718

Closed
wants to merge 2 commits into from
Closed

Conversation

bdeadman
Copy link
Collaborator

@bdeadman bdeadman commented May 2, 2024

Response to #607 and #708.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.87%. Comparing base (4f50b68) to head (58f55dd).
Report is 5 commits behind head on main.

❗ Current head 58f55dd differs from pull request most recent head b6965ca. Consider uploading reports for the commit b6965ca to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   69.89%   69.87%   -0.02%     
==========================================
  Files          23       23              
  Lines        2368     2370       +2     
  Branches      598      600       +2     
==========================================
+ Hits         1655     1656       +1     
- Misses        599      600       +1     
  Partials      114      114              

Added MDL number identifier, and corrected formatting in previous addition device and analysis ENUMs.
@FanwangM FanwangM self-assigned this May 8, 2024
@FanwangM
Copy link
Collaborator

This PR is replaced by #719.

@FanwangM FanwangM closed this May 13, 2024
@bdeadman bdeadman deleted the bjd-1 branch May 17, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants