Bump protoc version to 3.14.0 #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
=======================================
Coverage 75.59% 75.59%
=======================================
Files 21 21
Lines 1901 1901
Branches 457 457
=======================================
Hits 1437 1437
Misses 329 329
Partials 135 135 |
connorcoley
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that 3.14.0 includes protocolbuffers/protobuf#7379, which is required for correctly parsing
repeated floatfields in JS. To be clear, protoc 3.13.0 still works since the changes are to the JS parsing code, but let's keep the ord-editor and ord-schema protobuf versions in sync (ord-editor protobuf version is updated in open-reaction-database/ord-editor#56).