Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ord-schema tests #716

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Fix ord-schema tests #716

merged 9 commits into from
Apr 12, 2024

Conversation

skearnes
Copy link
Collaborator

@skearnes skearnes commented Apr 12, 2024 •
edited

Fixes #715

  • Skips some ORM tests when the RDKit postgres cartridge is not available
  • Updates the ML application notebook (and removes the saved model from git)

@skearnes skearnes changed the title Skip tests if rdkit postgres cartridge is not available Fix ord-schema tests Apr 12, 2024
@skearnes skearnes marked this pull request as ready for review April 12, 2024 19:33
@skearnes skearnes enabled auto-merge (squash) April 12, 2024 19:37
miori-nd
miori-nd approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@miori-nd miori-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skearnes skearnes merged commit 9c2607e into main Apr 12, 2024
21 checks passed
@skearnes skearnes deleted the refresh branch April 12, 2024 20:50
@bdeadman
Copy link
Collaborator

Thanks @skearnes and @miori-nd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miori-nd miori-nd miori-nd approved these changes

@bdeadman bdeadman Awaiting requested review from bdeadman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ord-schema tests are failing
3 participants
@skearnes @bdeadman @miori-nd