Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Proposal: Feature Flag Semantic Conventions #2042

Merged
merged 26 commits into from
May 31, 2024

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 5, 2024

This proposes a new project to stabilize feature flag semantic conventions. Created as a draft for now while we fill out the rest of the project template.

TODOs:

  • list engineers committed to working on the project
  • list prototype engineers and maintainers committed to review

@dyladan dyladan changed the title Add draft feature flag project proposal Feature flag project proposal Apr 5, 2024
@svrnm svrnm added the Project Proposal Submitting a filled out project template label Apr 8, 2024
@danielgblanco danielgblanco changed the title Feature flag project proposal Project Proposal: Feature Flag Semantic Conventions Apr 9, 2024
projects/feature-flag.md Outdated Show resolved Hide resolved
projects/feature-flag.md Outdated Show resolved Hide resolved
projects/feature-flag.md Outdated Show resolved Hide resolved
projects/feature-flag.md Outdated Show resolved Hide resolved
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
@beeme1mr
Copy link

beeme1mr commented May 7, 2024

@askpt has volunteered to support us from a .NET perspective.

https://cloud-native.slack.com/archives/C06RT64NP37/p1715113701675879?thread_ts=1714057336.076709&cid=C06RT64NP37

projects/feature-flag.md Outdated Show resolved Hide resolved
dyladan and others added 2 commits May 9, 2024 09:42
Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com>
@lukas-reining
Copy link

As said @dyladan, I would love to be in for that. (OpenFeature TC)

@dyladan
Copy link
Member Author

dyladan commented May 9, 2024

Project leads/sponsors have approved. I can't approve because I opened the PR but to be clear, I do approve.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some wording suggestions (transaction to trace, monitoring to observability)

projects/feature-flag.md Outdated Show resolved Hide resolved
projects/feature-flag.md Outdated Show resolved Hide resolved
projects/feature-flag.md Outdated Show resolved Hide resolved
projects/feature-flag.md Outdated Show resolved Hide resolved
@julealgon
Copy link

@svrnm

...monitoring to observability

Is this a known preferred naming convention? What about calling it "telemetry" instead, wouldn't that be even more consistent with "OpenTelemetry"?

projects/feature-flag.md Outdated Show resolved Hide resolved
Copy link

linux-foundation-easycla bot commented May 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@dyladan
Copy link
Member Author

dyladan commented May 21, 2024

not sure what's causing easycla to fail on some of the commits

@svrnm
Copy link
Member

svrnm commented May 22, 2024

not sure what's causing easycla to fail on some of the commits

I think the issue are the emails in Co-Authored-by, since this is a new feature in easyCLA to be verified as well, see

https://github.com/communitybridge/easycla/releases

Everyone might need to check if their @users.noreply.github.com address is also covered by the easyCLA

@askpt
Copy link
Contributor

askpt commented May 22, 2024

not sure what's causing easycla to fail on some of the commits

I think the issue are the emails in Co-Authored-by, since this is a new feature in easyCLA to be verified as well, see

https://github.com/communitybridge/easycla/releases

Everyone might need to check if their @users.noreply.github.com address is also covered by the easyCLA

I just signed in using my @users.noreply.github.com address and primary address. It seems it didn't update automatically.

@svrnm
Copy link
Member

svrnm commented May 22, 2024

see communitybridge/easycla#4329

@jarias-lfx
Copy link

/easycla

@dyladan dyladan merged commit 6614830 into open-telemetry:main May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project Proposal Submitting a filled out project template
Projects
Status: Potential Projects
Development

Successfully merging this pull request may close these issues.

None yet