Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic conventions tooling meeting. #2113

Merged
merged 5 commits into from
May 17, 2024

Conversation

jsuereth
Copy link
Contributor

I wasn't sure whether to keep same sponsors as existing Semconv WG, so I removed anyone I hadn't asked explicitly (so just myself for now).

For now, we need to at least publicize the meeting.

@svrnm
Copy link
Member

svrnm commented May 15, 2024

Can you apply the update to sigs.yml and then run make table-generation to have the README updated from there automatically, otherwise the next PR will overwrite your change.

@jsuereth
Copy link
Contributor Author

make table-generation doesn't work for me. Could you move to a docker-based tooling solution so we don't have to fight python environments?

@svrnm
Copy link
Member

svrnm commented May 15, 2024

There is a docker based fallback:

		docker run --rm -v ${PWD}:/repo -w /repo python:3-alpine python ./scripts/update-sig-tables.py --install; \

but I can make this the default/the only solution

@jsuereth
Copy link
Contributor Author

@svrnm Yeah, the docker command worked. I see your if/else. The issue is I have python, but not one compatible with your script, so it failed completely. I'm not sure if you can improve the python env detection or just give up and default to docker the way we do in the Spec / semconv builds...

@svrnm
Copy link
Member

svrnm commented May 16, 2024

@svrnm Yeah, the docker command worked. I see your if/else. The issue is I have python, but not one compatible with your script, so it failed completely. I'm not sure if you can improve the python env detection or just give up and default to docker the way we do in the Spec / semconv builds...

I think I just go with docker like the spec / semconv builds

@trask trask merged commit a39686e into open-telemetry:main May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants