Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the TC responsible for adding new members #923

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Make the TC responsible for adding new members #923

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb5a954
GC to TC in membership document
SergeyKanzhelev Nov 26, 2021
206df8c
Merge branch 'main' into gctotc
SergeyKanzhelev Jan 3, 2022
4bb500c
Update community-membership.md
SergeyKanzhelev Jan 4, 2022
a6a17eb
Merge branch 'main' into gctotc
bogdandrutu Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions community-membership.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ below.

Members are continuously active contributors in the community. They can have
issues and PRs assigned to them. Members are expected to participate in SIG or
SIGs and remain active contributors to the community.
SIGs and remain active contributors to the community.

Defined by: Member of the OpenTelemetry GitHub organization

Expand Down Expand Up @@ -71,10 +71,10 @@ Defined by: Member of the OpenTelemetry GitHub organization
template](https://github.com/open-telemetry/community/blob/master/.github/ISSUE_TEMPLATE/membership.md))
- Make sure that the list of contributions included is representative of your
work on the project.
- Have your sponsoring reviewers reply confirmation of sponsorship: `+1`
- Have your sponsoring reviewers reply confirmation of sponsorship: `I support`
- Once your sponsors have responded, your request will be reviewed by the
Governance Committee. Any GC member can review the requirements and add
Members to the GitHub org.
Technical Committee (TC). Any TC member can review the requirements and add
Copy link
Member

@alolita alolita Jan 3, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the membership approver pool not being expanded rather than being changed from GC to TC?
I would prefer this approver pool to be GC+TC rather than TC only since there have been bandwidth issues from the TC with the current backlog of responsibilities.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding this isn't about the approvals, but about actually adding new members to the org, which requires permissions that the GC does not need (legislative vs. executive branch analogy).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the process is already defined by the GC and there is not too much to "approve", we just need to follow/enforce the rule.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this right. I suggest setting up a GitHub Admin team (similar to how k8s does this). This GH admin team would take ownership and execution of adding new members to the project. Imo delegating this responsibility to the TC may not help evaluation velocity. @SergeyKanzhelev who is on the TC (and helped enormously in ensuring membership requests were processed quickly while on the GC) may still end up doing the work and may still result in a SPOF situation within the TC.

I also think this is a great opportunity for other active contributors and members on the project to get more involved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alolita can you clarify on the next steps you propose? I think creating the new "Admin" team will take discussions, changing the charter of the TC, etc., so probably we can start that process (GC has to decide) but I would not block this especially as you said @SergeyKanzhelev being the person who did the most work.

GC right now, by the charter, does not have admin rights in the org, so not sure adding GC is feasible right now. Maybe this can also be discussed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is correcting factual issue. As per creating GitHub Admin team, if there are enthusiasts who are interested in this, we can initiate the process. Definitely there are many aspects of GitHub management that can be documented and improved. @alolita do you want to create a github issue to track the idea and seek for volunteers?

Members to the GitHub org.

### Responsibilities and privileges

Expand All @@ -97,16 +97,16 @@ approver in addition to the reviews by *members.*

## Triager

Triagers assist the maintainers and approvers with project management and
backlog organization. The specific workflows and triage requirements depend on
Triagers assist the maintainers and approvers with project management and
backlog organization. The specific workflows and triage requirements depend on
the project, and are set by the project maintainers.

Defined by: [Triage permissions](https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#repository-access-for-each-permission-level),
with the names of the current Triagers commited to git, either in CONTRIBUTING,
CODEOWNERS, or the botom of the README.
Defined by: [Triage permissions](https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#repository-access-for-each-permission-level),
with the names of the current Triagers commited to git, either in CONTRIBUTING,
CODEOWNERS, or the bottom of the README.

Triagers may be code contributors, but writing code is not a requirement for
becoming a triager. Triagers are encouraged to be active participants in project
Triagers may be code contributors, but writing code is not a requirement for
becoming a triager. Triagers are encouraged to be active participants in project
meetings, chat rooms, and other discussion forums.

### Requirements
Expand Down