Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] New Unix converter to convert epoch timestamp to time.Time #27868

Closed
4 tasks
TylerHelmuth opened this issue Oct 19, 2023 · 8 comments
Closed
4 tasks
Assignees

Comments

@TylerHelmuth
Copy link
Member

Component(s)

pkg/ottl

Describe the issue you're reporting

[### Component(s)

pkg/ottl

Is your feature request related to a problem? Please describe.

OTTL has no way to create a time.Time from an epoch time.

Describe the solution you'd like

A new Unix converter function. similar to Golang's Unix function, that converts the integer input to a time.Time.

The function should have 2 parameters. The first parameter should be the seconds input and is a IntGetter. The second input should be an optional IntGetter and represents the nanoseconds.

The implementing PR should

  • Implement the function
  • Add new unit tests for the function
  • Add the function to pkg/ottl/ottlfuncs/functions.go
  • Update the README at pkg/ottl/ottlfuncs/README.md
@TylerHelmuth TylerHelmuth added help wanted Extra attention is needed good first issue Good for newcomers priority:p2 Medium pkg/ottl Contribfest labels Oct 19, 2023
@TylerHelmuth TylerHelmuth changed the title [pkg/ottl] New Unix converter to convert epoch timestamp to time.Time [pkg/ottl] New Unix converter to convert epoch timestamp to time.Time Oct 19, 2023
@TylerHelmuth TylerHelmuth removed help wanted Extra attention is needed good first issue Good for newcomers labels Oct 21, 2023
@kentquirk
Copy link
Member

I'll take this one.

@codeboten
Copy link
Contributor

All yours, thanks @kentquirk!

@iblancasa
Copy link
Contributor

I think this issue can be closed since it was solved as part of #29088

@TylerHelmuth
Copy link
Member Author

@iblancasa this issue has not yet been resolved. #29088 was closed since it is a duplicate of this issue.

@iblancasa
Copy link
Contributor

Oh. Sorry. I can work on it

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 20, 2024
@iblancasa
Copy link
Contributor

I'll apply the changes requested in the PR today

@github-actions github-actions bot removed the Stale label Mar 21, 2024
TylerHelmuth added a commit that referenced this issue Mar 26, 2024
Solves #27868.

---------

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@TylerHelmuth
Copy link
Member Author

Closed via #31556

rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
Solves open-telemetry#27868.

---------

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants