Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Add new ottl/Unix function #31556

Merged
merged 16 commits into from
Mar 26, 2024
Merged

[pkg/ottl] Add new ottl/Unix function #31556

merged 16 commits into from
Mar 26, 2024

Conversation

iblancasa
Copy link
Contributor

Solves #27868.

@iblancasa
Add new ottl/Unix function
b792183 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa
Add missing files
0117692 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa
Fix tests
4a024d5 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
93295fa 
…tor-contrib into feature/27868
@iblancasa iblancasa marked this pull request as ready for review March 5, 2024 20:10
@iblancasa iblancasa requested a review from a team as a code owner March 5, 2024 20:10
@iblancasa iblancasa changed the title Add new ottl/Unix function [pkg/ottl] Add new ottl/Unix function Mar 5, 2024
TylerHelmuth
TylerHelmuth reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some new tests to pkg/ottl/e2e.

pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit d590139 into open-telemetry:main Mar 26, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 26, 2024
@TylerHelmuth TylerHelmuth mentioned this pull request Apr 11, 2024
Closed
4 tasks
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this pull request May 8, 2024
@iblancasa @TylerHelmuth @rimitchell
[pkg/ottl] Add new ottl/Unix function (open-telemetry#31556)
730922a 
Solves open-telemetry#27868.

---------

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@djaglowski djaglowski

Labels
pkg/ottl
Projects
None yet
Milestone
v0.98.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iblancasa @TylerHelmuth @djaglowski