Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/opamp] Add support for user-specified non-identifying attributes #32107

Closed
BinaryFissionGames opened this issue Apr 2, 2024 · 2 comments · Fixed by #32153
Closed

[extension/opamp] Add support for user-specified non-identifying attributes #32107

BinaryFissionGames opened this issue Apr 2, 2024 · 2 comments · Fixed by #32153
Assignees
@BinaryFissionGames
Labels
enhancement New feature or request extension/opamp priority:p2 Medium

Comments

@BinaryFissionGames
Copy link
Contributor

BinaryFissionGames commented Apr 2, 2024 •
edited

Component(s)

extension/opamp

Is your feature request related to a problem? Please describe.

In the OpAMP spec, non-identifying attributes include "any user-defined attributes that the end user would like to associate with this Agent."

We would like to be able to add some extra attributes to the agent description this way.

Describe the solution you'd like

I think a simple solution would be to just have a section of the config that unmarshals to map[string]string, where the attributes can be specified:

extension:
  opamp:
    non_identifying_attributes:
      custom.attribute: value
      another.custom.attribute: "another value"

If one of the automatically filled non identifying attributes are specified (e.g. host.name, host.arch, os.type), I think the user-specified value of the attribute should act as an override for these attributes.

Describe alternatives you've considered

No response

Additional context

No response
@BinaryFissionGames BinaryFissionGames added enhancement New feature or request needs triage New item requiring triage labels Apr 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@evan-bradley evan-bradley added priority:p2 Medium and removed needs triage New item requiring triage labels Apr 2, 2024
@evan-bradley
Copy link
Contributor

Sounds good to me. I can't think of any reasons why we shouldn't add this.

@BinaryFissionGames BinaryFissionGames mentioned this issue Apr 3, 2024
Merged
@github-actions github-actions bot mentioned this issue Apr 9, 2024
Open
djaglowski pushed a commit that referenced this issue Apr 16, 2024
@BinaryFissionGames
[extension/opamp] Add config options to specify extra non-identifying…
c356157 
… attributes (#32153)

**Description:** <Describe what has changed.>
* Adds a new `agent_description.non_identifying_attributes` config
option to allow setting user-defined non-identifying attributes

**Link to tracking Issue:** Closes #32107

**Testing:**
Added unit tests
Manually tested against an OpAMP server

**Documentation:**
Added new parameter to extension docs
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
@BinaryFissionGames @rimitchell
[extension/opamp] Add config options to specify extra non-identifying…
660c51e 
… attributes (open-telemetry#32153)

**Description:** <Describe what has changed.>
* Adds a new `agent_description.non_identifying_attributes` config
option to allow setting user-defined non-identifying attributes

**Link to tracking Issue:** Closes open-telemetry#32107

**Testing:**
Added unit tests
Manually tested against an OpAMP server

**Documentation:**
Added new parameter to extension docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BinaryFissionGames BinaryFissionGames

Labels
enhancement New feature or request extension/opamp priority:p2 Medium
Projects
None yet
Milestone
No milestone
2 participants
@BinaryFissionGames @evan-bradley