[extension/opamp] Add config options to specify extra non-identifying attributes #32153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
evan-bradley,
portertech and
tigrannajaryan
BinaryFissionGames
force-pushed
the
feat/opamp-extension-user-defined-attributes
branch
from
3e29ed6
to
2ba803f
Compare
crobert-1
reviewed
Apr 3, 2024
crobert-1
approved these changes
Apr 3, 2024
JaredTan95
approved these changes
Apr 7, 2024
BinaryFissionGames
force-pushed
the
feat/opamp-extension-user-defined-attributes
branch
from
756338c
to
315f3dd
Compare
djaglowski
approved these changes
Apr 16, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
… attributes (open-telemetry#32153) **Description:** <Describe what has changed.> * Adds a new `agent_description.non_identifying_attributes` config option to allow setting user-defined non-identifying attributes **Link to tracking Issue:** Closes open-telemetry#32107 **Testing:** Added unit tests Manually tested against an OpAMP server **Documentation:** Added new parameter to extension docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
agent_description.non_identifying_attributesconfig option to allow setting user-defined non-identifying attributesLink to tracking Issue: Closes #32107
Testing:
Added unit tests
Manually tested against an OpAMP server
Documentation:
Added new parameter to extension docs