Revert "Adding a feature to prometheusexporter to export exemplars along with… (#9945)" #12074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong with… (open-telemetry#9945)" This reverts commit e5a0a29.
mx-psi
added
the
release:blocker
tigrannajaryan
approved these changes
Jul 5, 2022
|
@open-telemetry/collector-contrib-approvers I need a review here to merge this before tomorrow's release |
dmitryax
approved these changes
Jul 5, 2022
Konig-Corey
pushed a commit
to Konig-Corey/opentelemetry-collector-contrib
that referenced
this pull request
Jul 5, 2022
…ong with… (open-telemetry#9945)" (open-telemetry#12074) * Revert "Adding a feature to prometheusexporter to export exemplars along with… (open-telemetry#9945)" This reverts commit e5a0a29. * Remove release note for open-telemetry#9945
Konig-Corey
pushed a commit
to Konig-Corey/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2022
…ong with… (open-telemetry#9945)" (open-telemetry#12074) * Revert "Adding a feature to prometheusexporter to export exemplars along with… (open-telemetry#9945)" This reverts commit e5a0a29. * Remove release note for open-telemetry#9945
Konig-Corey
pushed a commit
to Konig-Corey/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2022
…ong with… (open-telemetry#9945)" (open-telemetry#12074) * Revert "Adding a feature to prometheusexporter to export exemplars along with… (open-telemetry#9945)" This reverts commit e5a0a29. * Remove release note for open-telemetry#9945
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
…ong with… (open-telemetry#9945)" (open-telemetry#12074) * Revert "Adding a feature to prometheusexporter to export exemplars along with… (open-telemetry#9945)" This reverts commit e5a0a29. * Remove release note for open-telemetry#9945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This reverts commit e5a0a29 and therefore PR #9945.
As reported in #9945 (comment), this PR can make the Prometheus exporter panic when sending bad data.
Since the PR has not yet been present in any Collector release, and after consulting with the release manager for the next release, we have decided to revert this PR to have more time to understand the issue.