Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/signalfx] [exporter/splunkhec] Remove max_connections config parameter #27611

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 11, 2023

Description:
The max_connections config setting were deprecated with #16837 and #16838. It has been 10 months since these changes have been made and it is time to remove this configuration setting altogether.

Link to tracking Issue:
#27610

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme
Copy link
Contributor Author

atoulme commented Oct 16, 2023

@dmitryax please review when you get a chance thanks!

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally should be two PRs :)

@dmitryax dmitryax changed the title Remove max_connections config parameter [exporter/signalfx] [exporter/splunkhec] Remove max_connections config parameter Oct 16, 2023
@dmitryax dmitryax merged commit b37a55e into open-telemetry:main Oct 16, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 16, 2023
@atoulme atoulme deleted the remove_max_connections branch October 16, 2023 18:29
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Oct 18, 2023
…g parameter (open-telemetry#27611)

**Description:**
The max_connections config setting were deprecated with
open-telemetry#16837
and
open-telemetry#16838.
It has been 10 months since these changes have been made and it is time
to remove this configuration setting altogether.

**Link to tracking Issue:**
open-telemetry#27610
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…g parameter (open-telemetry#27611)

**Description:**
The max_connections config setting were deprecated with
open-telemetry#16837
and
open-telemetry#16838.
It has been 10 months since these changes have been made and it is time
to remove this configuration setting altogether.

**Link to tracking Issue:**
open-telemetry#27610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants