Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/filelog] Implement specifying top n files to track when ordering #27844

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

BinaryFissionGames
Copy link
Contributor

Description:

  • Add a new ordering_criteria.top_n option, which allows a user to specify the number of files to track after ordering.
    • Default is 1, which was the existing behavior.

Link to tracking Issue: #23788

Testing:
Unit tests added.

Documentation:
Added new parameter to existing documentation.

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review October 18, 2023 17:28
@BinaryFissionGames BinaryFissionGames requested a review from a team as a code owner October 18, 2023 17:28
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple nits

pkg/stanza/fileconsumer/matcher/matcher.go Outdated Show resolved Hide resolved
pkg/stanza/fileconsumer/matcher/matcher.go Outdated Show resolved Hide resolved
pkg/stanza/fileconsumer/matcher/matcher_test.go Outdated Show resolved Hide resolved
@djaglowski djaglowski merged commit c44ad3c into open-telemetry:main Oct 18, 2023
76 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 18, 2023
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this pull request Oct 20, 2023
…ering (open-telemetry#27844)

**Description:**
* Add a new `ordering_criteria.top_n` option, which allows a user to
specify the number of files to track after ordering.
  * Default is 1, which was the existing behavior.

**Link to tracking Issue:** open-telemetry#23788

**Testing:**
Unit tests added.

**Documentation:**
Added new parameter to existing documentation.
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
…ering (open-telemetry#27844)

**Description:**
* Add a new `ordering_criteria.top_n` option, which allows a user to
specify the number of files to track after ordering.
  * Default is 1, which was the existing behavior.

**Link to tracking Issue:** open-telemetry#23788

**Testing:**
Unit tests added.

**Documentation:**
Added new parameter to existing documentation.
@Mrod1598 Mrod1598 deleted the feat/top_n_file_sorting branch October 30, 2023 17:05
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…ering (open-telemetry#27844)

**Description:**
* Add a new `ordering_criteria.top_n` option, which allows a user to
specify the number of files to track after ordering.
  * Default is 1, which was the existing behavior.

**Link to tracking Issue:** open-telemetry#23788

**Testing:**
Unit tests added.

**Documentation:**
Added new parameter to existing documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants