[receiver/windowseventlog] Add Execution and Security information to parsed event log #27864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
force-pushed
the
feat/windows-evlog/security-and-execution
branch
from
c2c989f
to
c72e2ed
Compare
pjanotti
reviewed
Oct 19, 2023
Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
pjanotti
approved these changes
Oct 20, 2023
| if len(details) > 0 { | ||
| body["details"] = details | ||
| } | ||
|
|
||
| if e.Security != nil && e.Security.UserID != "" { | ||
| body["security"] = map[string]any{ |
There was a problem hiding this comment.
nit: other locations on this file use map[string]interface{}
@djaglowski what is the general preference on this type of nit issue? Consistency, brevity, latest language patterns? (I have my preferences, but, the biggest one is following the practices of the repo/package).
Anyway, this is not material no need to hold merge because of it.
There was a problem hiding this comment.
Personally I'd prefer to take steps towards latest language patterns but I don't feel strongly about it here.
|
@djaglowski I think this is good to be merged, could you PTAL? |
djaglowski
approved these changes
Oct 24, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…parsed event log (open-telemetry#27864) **Description:** Adds parsing for Execution and Security sections of the event log, as defined in the schema here: https://learn.microsoft.com/en-us/windows/win32/wes/eventschema-systempropertiestype-complextype **Link to tracking Issue:** open-telemetry#27810 **Testing:** * Added some unit tests * Tested on a windows machine to make sure it parsed correctly on a real system --------- Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…parsed event log (open-telemetry#27864) **Description:** Adds parsing for Execution and Security sections of the event log, as defined in the schema here: https://learn.microsoft.com/en-us/windows/win32/wes/eventschema-systempropertiestype-complextype **Link to tracking Issue:** open-telemetry#27810 **Testing:** * Added some unit tests * Tested on a windows machine to make sure it parsed correctly on a real system --------- Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…parsed event log (open-telemetry#27864) **Description:** Adds parsing for Execution and Security sections of the event log, as defined in the schema here: https://learn.microsoft.com/en-us/windows/win32/wes/eventschema-systempropertiestype-complextype **Link to tracking Issue:** open-telemetry#27810 **Testing:** * Added some unit tests * Tested on a windows machine to make sure it parsed correctly on a real system --------- Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds parsing for Execution and Security sections of the event log, as defined in the schema here: https://learn.microsoft.com/en-us/windows/win32/wes/eventschema-systempropertiestype-complextype
Link to tracking Issue: #27810
Testing: