[cmd/opampsupervisor] Fix restart delay when agent process exits unexpectedly #30238
Conversation
srikanthccv
requested review from
evan-bradley,
atoulme,
tigrannajaryan and
a team
as code owners
|
Thank you for taking care of this. Could you add a changelog entry? |
|
I think the failed test is relevant. I will fix it. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
There was a problem hiding this comment.
@srikanthccv have you had a chance to look at the failing test?
|
Yes @codeboten, There were timers in other places as well. I will test out the changes and push the fix soon. |
|
I noticed I already added the CHANGELOG entry. PTAL. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Not stale, I didn't get a chance to look into the review comments yet. I will get back to this soon. |
| c.doneCh = make(chan struct{}, 1) | ||
| c.exitCh = make(chan struct{}, 1) |
There was a problem hiding this comment.
I think we should just create these once on startup then drain them above. That way we can let the caller figure out multicasting.
There was a problem hiding this comment.
Sorry for tripping, I was reactively making changes to comments. Let me go through the changeset again and address the comment.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Reset should called only on stopped or expired timers with drained channels. If the timer already expired (and the channel was not cleared) it reads from the timer's channel to clear it.
Link to tracking Issue:
Fixes #27891
Testing:
Manually verified while working on something else