[cmd/opampsupervisor] Fix restart delay when agent process exits unexpectedly #32150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
tigrannajaryan
changed the title
BinaryFissionGames
approved these changes
Apr 3, 2024
evan-bradley
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Really excited to have this fixed, thanks.
I think the way we're handling channels is the best we can do, but looks a little funny. I just added a few suggestions to explain why we're doing what we are. If anyone else has ideas for more idiomatic ways to make these behave sensibly, I'm open to other suggestions.
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
|
@srikanthccv It looks like there's a linting error, could you look into it? |
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…pectedly (open-telemetry#32150) **Description:** Reset should called only on stopped or expired timers with drained channels. If the timer already expired (and the channel was not cleared) it reads from the timer's channel to clear it. **Link to tracking Issue:** Fixes open-telemetry#27891 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reset should called only on stopped or expired timers with drained channels. If the timer already expired (and the channel was not cleared) it reads from the timer's channel to clear it.
Link to tracking Issue: Fixes #27891
Testing:
Documentation: