[receiver/hostmetricsreceiver] cpu scraper - extract cpu count when metric is enabled #32173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etric is enabled Signed-off-by: Dani Louca <dlouca@splunk.com>
|
Failing trace correctness test is frequency of #27295, unrelated to this change. |
crobert-1
approved these changes
Apr 4, 2024
atoulme
approved these changes
Apr 5, 2024
dmitryax
approved these changes
Apr 11, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…etric is enabled (open-telemetry#32173) **Description:** As described in open-telemetry#32133 , in windows, the CPU count results of a wmi call with a hardcoded context timeout of 3 seconds. This leads to an error when the wmi is slow or system is under heavy load, causing all the collected metrics to not be emitted. The CPU count metrics, logical and physical, are not enabled by default and there is no reason to calculate it unless it's enabled. **Link to tracking Issue:** open-telemetry#32133 **Testing:** unit test has been validated **Documentation:** <Describe the documentation added.> Signed-off-by: Dani Louca <dlouca@splunk.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As described in #32133 , in windows, the CPU count results of a wmi call with a hardcoded context timeout of 3 seconds.
This leads to an error when the wmi is slow or system is under heavy load, causing all the collected metrics to not be emitted.
The CPU count metrics, logical and physical, are not enabled by default and there is no reason to calculate it unless it's enabled.
Link to tracking Issue:
#32133
Testing:
unit test has been validated
Documentation: