-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awscontainerinsight] Fix memory leak on shutdown in k8s API server #32405
Open
crobert-1
wants to merge
6
commits into
open-telemetry:main
Choose a base branch
from
crobert-1:goleak_awscontainerinsights_k8sapiserver
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[receiver/awscontainerinsight] Fix memory leak on shutdown in k8s API server #32405
crobert-1
wants to merge
6
commits into
open-telemetry:main
from
crobert-1:goleak_awscontainerinsights_k8sapiserver
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
fatsheep9146
approved these changes
May 10, 2024
nicely ping @Aneurysm9 for review |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change has 4 main parts:
Shutdown
as it has its own running goroutines that need shutdown to avoid leaking.Shutdown
in the failure scenarios ofNew
. This is required because once again, goroutines are started during the k8s API server'sNew
call stack. Since it returnsnil
on error, there's no way to shutdown once it returns. This meansShutdown
must be called on error.goleak
checks to help ensure no goroutines are being leaked.Link to tracking Issue:
#30438
Testing:
All existing tests are passing, as well as added
goleak
checks.