[connector/failover] Fix flaky test #32419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akats7
requested review from
djaglowski,
fatsheep9146 and
a team
as code owners
djaglowski
approved these changes
Apr 16, 2024
djaglowski
changed the title
|
Thanks for addressing and resolving so quickly @akats7, really appreciate your help here! |
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Update test structure to fix flaky behavior, originally seemed to fail every 1-2k runs from my local testing. **Link to tracking Issue:** <Issue number if applicable> resolves open-telemetry#32396 **Testing:** <Describe what testing was performed and which tests were added.> Added test method to directly trigger retry for testing, Rerun 10k+ times **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update test structure to fix flaky behavior, originally seemed to fail every 1-2k runs from my local testing.
Link to tracking Issue:
resolves #32396
Testing:
Added test method to directly trigger retry for testing, Rerun 10k+ times
Documentation: