[pkg/stanza] always register operator to DefaultRegistry. Double chec… #32478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k state in featuregate when unmarshal configuration.
|
Depending on open-telemetry/opentelemetry-collector#9983 merge, the code will fail to build |
djaglowski
reviewed
Apr 17, 2024
Comment on lines
-29
to
-31
| if jsonArrayParserFeatureGate.IsEnabled() { | ||
| operator.Register(operatorType, func() operator.Builder { return NewConfig() }) | ||
| } |
There was a problem hiding this comment.
Please just move this check into the Build function and return an error if it's not enabled.
There was a problem hiding this comment.
Thank you for your review.
|
@djaglowski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:*
bug: collector launch fail with '--feature-gates=logs.jsonParserArray'
how to fix:
func init()always register operator tooperator.DefaultRegistry.Gate.operatorTypedouble check operator state infeaturegate.globalRegistrywhen unmarshal configuration. Because id and operatorType are not the same string. (id: "logs.jsonParserArray", operatorType: "json_array_parser")depend on：open-telemetry/opentelemetry-collector#9983
Link to tracking Issue:
#32313