-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/stanza] when the 'jsonArrayParserFeatureGate' is disabled, the func 'Build' returns an error #32501
Merged
djaglowski
merged 4 commits into
open-telemetry:main
from
li-zeyuan:fix-jsonarrayparser-build
Apr 19, 2024
Merged
[pkg/stanza] when the 'jsonArrayParserFeatureGate' is disabled, the func 'Build' returns an error #32501
djaglowski
merged 4 commits into
open-telemetry:main
from
li-zeyuan:fix-jsonarrayparser-build
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, the functionality looks correct to me now. Just a few nits for changelog and tests.
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
build-and-test / coverage failed. Looks like it's GitHub rate limit. error - 2024-04-18 14:44:56,662 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 1017 seconds."}
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/Wandalen/codecov-action/dist/codecov' failed with exit code 1
Error: Process returned exit code 1 |
github-actions
bot
added
processor/logstransform
Logs Transform processor
receiver/azureeventhub
receiver/filelog
receiver/journald
receiver/namedpipe
receiver/otlpjsonfile
receiver/sqlquery
SQL query receiver
receiver/syslog
receiver/tcplog
receiver/udplog
receiver/windowseventlog
labels
Apr 19, 2024
github-actions
bot
requested review from
armstrmi,
cparkins,
dehaansa,
pjanotti,
sinkingpoint and
sumo-drosiek
April 19, 2024 14:29
djaglowski
approved these changes
Apr 19, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…unc 'Build' returns an error (open-telemetry#32501) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> bug: - collector launch fail with '--feature-gates=logs.jsonParserArray' how to fix: 1. `func init()` always register operator to `operator.DefaultRegistry`. 2. when the `jsonArrayParserFeatureGate` is disabled, the func `Build` returns an error. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#32313 --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg/stanza
processor/logstransform
Logs Transform processor
receiver/azureeventhub
receiver/filelog
receiver/journald
receiver/namedpipe
receiver/otlpjsonfile
receiver/sqlquery
SQL query receiver
receiver/syslog
receiver/tcplog
receiver/udplog
receiver/windowseventlog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
bug:
how to fix:
func init()
always register operator tooperator.DefaultRegistry
.jsonArrayParserFeatureGate
is disabled, the funcBuild
returns an error.Link to tracking Issue:
#32313