Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] when the 'jsonArrayParserFeatureGate' is disabled, the func 'Build' returns an error #32501

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

li-zeyuan
Copy link
Contributor

Description:

bug:

  • collector launch fail with '--feature-gates=logs.jsonParserArray'

how to fix:

  1. func init() always register operator to operator.DefaultRegistry.
  2. when the jsonArrayParserFeatureGate is disabled, the func Build returns an error.

Link to tracking Issue:
#32313

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the functionality looks correct to me now. Just a few nits for changelog and tests.

.chloggen/fix-jsonarrayparser-build.yaml Outdated Show resolved Hide resolved
pkg/stanza/operator/parser/jsonarray/parser_test.go Outdated Show resolved Hide resolved
@li-zeyuan
Copy link
Contributor Author

build-and-test / coverage failed. Looks like it's GitHub rate limit.

error - 2024-04-18 14:44:56,662 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 1017 seconds."}
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/Wandalen/codecov-action/dist/codecov' failed with exit code 1
Error: Process returned exit code 1

@djaglowski djaglowski merged commit 772cbc6 into open-telemetry:main Apr 19, 2024
155 of 156 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 19, 2024
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this pull request May 8, 2024
…unc 'Build' returns an error (open-telemetry#32501)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
bug: 
- collector launch fail with '--feature-gates=logs.jsonParserArray'

how to fix:
1. `func init()` always register operator to `operator.DefaultRegistry`.
2. when the `jsonArrayParserFeatureGate` is disabled, the func `Build`
returns an error.

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#32313

---------

Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants