Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/sqlserver] Add more metrics #32932

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 32 additions & 0 deletions .chloggen/sqlserver_add_perf_counter_query.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: sqlserverreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add more metrics

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [29865]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
Added metrics are:
- sqlserver.resource_pool.disk.throttled.read.rate
- sqlserver.resource_pool.disk.throttled.write.rate
- sqlserver.processes.blocked
These metrics are only available when directly connecting to the SQL server instance

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
30 changes: 30 additions & 0 deletions receiver/sqlserverreceiver/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,36 @@ This metric is only available when the receiver is configured to directly connec
| logical_filename | The logical filename of the file being monitored. | Any Str |
| file_type | The type of file being monitored. | Any Str |

### sqlserver.processes.blocked

The number of processes that are currently blocked

This metric is only available when the receiver is configured to directly connect to SQL Server.

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| {processes} | Gauge | Int |

### sqlserver.resource_pool.disk.throttled.read.rate

The number of read operations that were throttled in the last second

This metric is only available when the receiver is configured to directly connect to SQL Server.

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| {reads}/s | Gauge | Int |

### sqlserver.resource_pool.disk.throttled.write.rate

The number of write operations that were throttled in the last second

This metric is only available when the receiver is configured to directly connect to SQL Server.

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| {writes}/s | Gauge | Double |

## Resource Attributes

| Name | Description | Values | Enabled |
Expand Down
8 changes: 8 additions & 0 deletions receiver/sqlserverreceiver/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ func setupQueries(cfg *Config) []string {
queries = append(queries, getSQLServerDatabaseIOQuery(cfg.InstanceName))
}

if cfg.MetricsBuilderConfig.Metrics.SqlserverResourcePoolDiskThrottledReadRate.Enabled ||
cfg.MetricsBuilderConfig.Metrics.SqlserverResourcePoolDiskThrottledWriteRate.Enabled ||
cfg.MetricsBuilderConfig.Metrics.SqlserverLockWaitRate.Enabled ||
cfg.MetricsBuilderConfig.Metrics.SqlserverProcessesBlocked.Enabled {

queries = append(queries, getSQLServerPerformanceCounterQuery(cfg.InstanceName))
}

return queries
}

Expand Down
54 changes: 33 additions & 21 deletions receiver/sqlserverreceiver/internal/metadata/generated_config.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.