Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otlptext support for exponential histogram #4642

Merged
merged 2 commits into from Jan 7, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jan 5, 2022

Description:
Add support for printing OTLP exponential histograms

Link to tracking Issue:
Fixes #4641

Testing:

I ran go test -v with a modified test to verify that the printed format (which the test does not actually validate for any data point) is correct.

The math equations used here are copied from open-telemetry/opentelemetry-go#2393 where they have been extensively tested.

@jmacd jmacd requested a review from a team as a code owner January 5, 2022 20:33
@jmacd jmacd requested a review from codeboten January 5, 2022 20:33
@project-bot project-bot bot added this to In progress in Collector Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #4642 (575ecf1) into main (60823e2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4642      +/-   ##
==========================================
+ Coverage   90.46%   90.50%   +0.04%     
==========================================
  Files         181      181              
  Lines       10611    10658      +47     
==========================================
+ Hits         9599     9646      +47     
  Misses        788      788              
  Partials      224      224              
Impacted Files Coverage Δ
internal/otlptext/databuffer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60823e2...575ecf1. Read the comment docs.

@jmacd jmacd added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 5, 2022
Collector automation moved this from In progress to Reviewer approved Jan 7, 2022
@bogdandrutu bogdandrutu merged commit aadec29 into open-telemetry:main Jan 7, 2022
Collector automation moved this from Reviewer approved to Done Jan 7, 2022
@jmacd jmacd deleted the jmacd/otlptextexpohisto branch January 7, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

otlptext support for ExponentialHistogram
3 participants