Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Semantic Convention Schema URL definition for 1.5.0 and 1.6.1 #5103

Merged
merged 1 commit into from Mar 28, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Mar 28, 2022

This change fixes the sem conv SchemaURL values, as reported in #5090 (comment)

@dmitryax dmitryax requested a review from a team as a code owner March 28, 2022 03:59
@dmitryax
Copy link
Member Author

This is technically a breaking change, so we need to make sure that this is needed indeed. I'll keep it in draft for now

cc @Aneurysm9 @bogdandrutu

@dmitryax dmitryax marked this pull request as draft March 28, 2022 04:00
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #5103 (471a8e4) into main (7fe86bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5103   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files         183      183           
  Lines       11023    11023           
=======================================
  Hits         9936     9936           
  Misses        865      865           
  Partials      222      222           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe86bf...471a8e4. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good fix.

/cc @tigrannajaryan

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is definitely a bug. The correct URLs don't have "v" prefix, see the Schema Files directory: https://github.com/open-telemetry/opentelemetry-specification/tree/main/schemas

Since Schemas at OpenTelemetry are still Experimental we are free to make this breaking change (really a bug fix).

@dmitryax dmitryax marked this pull request as ready for review March 28, 2022 15:57
@dmitryax dmitryax added the ready-to-merge Code review completed; ready to merge by maintainers label Mar 28, 2022
@bogdandrutu bogdandrutu merged commit 027b4a3 into open-telemetry:main Mar 28, 2022
@dmitryax dmitryax deleted the fix-schema-url branch March 29, 2022 18:47
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants