Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to validate presence of all semconv files #5106

Merged
merged 1 commit into from Mar 28, 2022
Merged

Add a test to validate presence of all semconv files #5106

merged 1 commit into from Mar 28, 2022

Conversation

dmitryax
Copy link
Member

This tests validates that all files needed for the new model/semconv release are created .

@dmitryax dmitryax requested a review from a team as a code owner March 28, 2022 21:12
@dmitryax dmitryax requested a review from codeboten March 28, 2022 21:12
@project-bot project-bot bot added this to In progress in Collector Mar 28, 2022
@dmitryax
Copy link
Member Author

dmitryax commented Mar 28, 2022 •
edited

The test is failing until #5091 is merged

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 28, 2022
@dmitryax dmitryax mentioned this pull request Mar 28, 2022
Merged
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #5106 (4e26b44) into main (543ed8a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5106      +/-   ##
==========================================
- Coverage   90.04%   90.00%   -0.04%     
==========================================
  Files         183      183              
  Lines       11035    11035              
==========================================
- Hits         9936     9932       -4     
- Misses        877      880       +3     
- Partials      222      223       +1
Impacted Files Coverage Δ
model/internal/pdata/common.go 93.54% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543ed8a...4e26b44. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Mar 28, 2022
@tigrannajaryan tigrannajaryan merged commit 8c54787 into open-telemetry:main Mar 28, 2022
@dmitryax dmitryax deleted the add-tests-for-semver branch March 29, 2022 18:47
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
@dmitryax @Nicholaswang
Add a test to validate presence of all semconv files (open-telemetry#…
625927c 
…5106)

This tests validates that all files needed for the new model/semconv release are created .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Collector
  
Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmitryax @tigrannajaryan