Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove unused opencensus code #9108

Merged

Conversation

codeboten
Copy link
Contributor

Follows #9102

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07a00ff) 90.18% compared to head (01b1da2) 90.24%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9108      +/-   ##
==========================================
+ Coverage   90.18%   90.24%   +0.05%     
==========================================
  Files         345      344       -1     
  Lines       18019    17932      -87     
==========================================
- Hits        16251    16182      -69     
+ Misses       1438     1421      -17     
+ Partials      330      329       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu
Copy link
Member

I think this needs to be merged after we remove the gate. So 3-4 versions?

@codeboten
Copy link
Contributor Author

I think this needs to be merged after we remove the gate. So 3-4 versions?

@bogdandrutu correct, this PR is after #9102 which will be merged after v0.92.0 is released

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Dec 31, 2023
@codeboten codeboten force-pushed the codeboten/cleanup-more-census-deps branch from fa74b6e to 9849e46 Compare January 16, 2024 23:54
@codeboten codeboten force-pushed the codeboten/cleanup-more-census-deps branch from 9849e46 to 2a0ede5 Compare January 29, 2024 20:18
@codeboten codeboten marked this pull request as ready for review January 29, 2024 20:21
@codeboten codeboten requested a review from a team as a code owner January 29, 2024 20:21
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, lots of code going away :)

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

We can also remove goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start") from the goleak tests now :)

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

Alex Boten added 2 commits January 30, 2024 09:23
This is cleaning up opencensus code after the feature gate is marked stable.

Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten force-pushed the codeboten/cleanup-more-census-deps branch from 2a0ede5 to 01b1da2 Compare January 30, 2024 17:31
@codeboten codeboten merged commit 9c71774 into open-telemetry:main Jan 30, 2024
32 checks passed
@codeboten codeboten deleted the codeboten/cleanup-more-census-deps branch January 30, 2024 18:19
@github-actions github-actions bot added this to the next release milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants