ruby: switch to -slim image
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I had invested, say, a mere modicum of effort into understanding what needed to be done to use a `-slim` image in the first place, then we would have included this in #109 from the start. However, I clearly did not. 馃う This change switches us to the `-slim` image, and installs the one thing we actually need to build `puma`: Debian's `build-essential` package.
|
cc @cartersocha 鈽濓笍 |
cartersocha
approved these changes
Jun 6, 2022
cartersocha
added a commit
that referenced
this pull request
Jun 6, 2022
|
@ahayworth I'm actually getting bugs now. Maybe didn't sync my review branch correctly |
|
But email service isn't working |
|
|
|
@cartersocha did you rebuild all the images? You need to rebuild the go images I believe. |
GaryPWhite
pushed a commit
to wayfair-contribs/opentelemetry-demo
that referenced
this pull request
Jun 30, 2022
If I had invested, say, a mere modicum of effort into understanding what needed to be done to use a `-slim` image in the first place, then we would have included this in open-telemetry#109 from the start. However, I clearly did not. 馃う This change switches us to the `-slim` image, and installs the one thing we actually need to build `puma`: Debian's `build-essential` package.
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
If I had invested, say, a mere modicum of effort into understanding what needed to be done to use a `-slim` image in the first place, then we would have included this in open-telemetry#109 from the start. However, I clearly did not. 馃う This change switches us to the `-slim` image, and installs the one thing we actually need to build `puma`: Debian's `build-essential` package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If I had invested, say, a mere modicum of effort into understanding what
needed to be done to use a
-slimimage in the first place, then wewould have included this in #109 from the start. However, I clearly did not. 馃う
This change switches us to the
-slimimage, and installs the one thingwe actually need to build
puma: Debian'sbuild-essentialpackage.