Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource detection to checkout service #662

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 27, 2022

Changes

Similar to #648 & #651 this adds more resources being detected to the checkout service.

Screenshot 2022-12-27 at 23 35 07

Merge Requirements

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs folder

Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team as a code owner December 27, 2022 22:35
Signed-off-by: svrnm <neumanns@cisco.com>
@fatsheep9146
Copy link
Contributor

Thanks for addition, looks good to me.
BTW I wonder what about the metricsprovider, will you add in the future?

Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm
Copy link
Member Author

svrnm commented Dec 28, 2022

Thanks for addition, looks good to me. BTW I wonder what about the metricsprovider, will you add in the future?

Haven't thought about it to be honest, I fixed that now :)

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julianocosta89
Copy link
Member

@svrnm just out of curiosity, from where the container.id comes from?
I've tested the PR and only got host.name, which has the initial part of the container id, and not the whole ID as you have in the screenshot.
BTW: Tested it out just with docker.

@mviitane
Copy link
Member

mviitane commented Jan 2, 2023

Same for me.
container.id is not visible, host.name is visible
When looking at other services like paymentservice, I can see container.id just fine, so shouldn't be a problem in the docker environment.

@svrnm
Copy link
Member Author

svrnm commented Jan 2, 2023

Same here, Limitation rg cgroup v2. PR is in the making as well:

open-telemetry/opentelemetry-go#3508

@cartersocha
Copy link
Contributor

I think the changelog has a conflict from the cart service pr but ready to merge when resolved

@fatsheep9146
Copy link
Contributor

@cartersocha I fix the conflicts. I think the pr is ready to merged.

@cartersocha
Copy link
Contributor

https://giphy.com/gifs/luffy-zKBcZUw49Sxtm

@fatsheep9146

@cartersocha cartersocha merged commit 85c268f into open-telemetry:main Jan 7, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants