-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resources.Process] Rename process detector namespace #1717
[Resources.Process] Rename process detector namespace #1717
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
+ Coverage 73.91% 76.26% +2.34%
==========================================
Files 267 298 +31
Lines 9615 11622 +2007
==========================================
+ Hits 7107 8863 +1756
- Misses 2508 2759 +251 Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matt-hensley, I have merged changes related to creating bugfixes/features to this branch.
Couple of comments added to specific files.
What is more important we need changelog entry containing two thiings.
- Package rename
- How to migrate from old construction to the new one.
# Conflicts: # .github/ISSUE_TEMPLATE/bug_report.yml # .github/ISSUE_TEMPLATE/feature_request.yml # .github/workflows/ci.yml # opentelemetry-dotnet-contrib.sln
Changes
Changes are following guidelines in #1610.
AddProcessDetector
extension method forResourceBuilder
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes