Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.Process] Rename process detector namespace #1717

Merged
merged 11 commits into from
May 15, 2024

Conversation

matt-hensley
Copy link
Contributor

Changes

Changes are following guidelines in #1610.

  • Renames OpenTelemetry.ResourceDetectors.Process to OpenTelemetry.Resources.Process
  • Makes detector internal
  • Adds AddProcessDetector extension method for ResourceBuilder

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.26%. Comparing base (71655ce) to head (cd77963).
Report is 239 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
+ Coverage   73.91%   76.26%   +2.34%     
==========================================
  Files         267      298      +31     
  Lines        9615    11622    +2007     
==========================================
+ Hits         7107     8863    +1756     
- Misses       2508     2759     +251     
Flag Coverage Δ
unittests-Exporter.Geneva 64.39% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.39% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 78.78% <ø> (?)
unittests-Instrumentation.Http 81.79% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Process 81.81% <0.00%> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...OpenTelemetry.Resources.Process/ProcessDetector.cs 100.00% <ø> (ø)
...ources.Process/ProcessResourceBuilderExtensions.cs 0.00% <0.00%> (ø)

... and 281 files with indirect coverage changes

@Kielek Kielek added comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:resources.process Things related to OpenTelemetry.Resources.Process and removed comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process labels May 13, 2024
@Kielek Kielek changed the title [ResourceDetectors.Process] Rename process detector namespace [Resources.Process] Rename process detector namespace May 13, 2024
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matt-hensley, I have merged changes related to creating bugfixes/features to this branch.

Couple of comments added to specific files.
What is more important we need changelog entry containing two thiings.

  1. Package rename
  2. How to migrate from old construction to the new one.

.github/workflows/package-ResourceDetectors.Process.yml Outdated Show resolved Hide resolved
@matt-hensley matt-hensley marked this pull request as ready for review May 13, 2024 18:57
@matt-hensley matt-hensley requested a review from a team as a code owner May 13, 2024 18:57
@matt-hensley matt-hensley requested a review from Kielek May 13, 2024 18:57
# Conflicts:
#	.github/ISSUE_TEMPLATE/bug_report.yml
#	.github/ISSUE_TEMPLATE/feature_request.yml
#	.github/workflows/ci.yml
#	opentelemetry-dotnet-contrib.sln
@Kielek Kielek merged commit cf0258d into open-telemetry:main May 15, 2024
153 of 154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.process Things related to OpenTelemetry.Resources.Process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants