Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.ProcessRuntime] Rename processruntime detector namespace #1767

Merged

Conversation

matt-hensley
Copy link
Contributor

@matt-hensley matt-hensley commented May 14, 2024

Changes

Changes are following guidelines in #1610.

  • Renames OpenTelemetry.ResourceDetectors.ProcessRuntime to OpenTelemetry.Resources.ProcessRuntime
  • Makes detector internal
  • Adds AddProcessRuntimeDetector extension method for ResourceBuilder

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@matt-hensley matt-hensley marked this pull request as ready for review May 14, 2024 16:51
@matt-hensley matt-hensley requested a review from a team as a code owner May 14, 2024 16:51
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.78%. Comparing base (71655ce) to head (d20aa5a).
Report is 248 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
- Coverage   73.91%   73.78%   -0.14%     
==========================================
  Files         267      293      +26     
  Lines        9615    10859    +1244     
==========================================
+ Hits         7107     8012     +905     
- Misses       2508     2847     +339     
Flag Coverage Δ
unittests-Exporter.Geneva 61.18% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.39% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 78.78% <ø> (?)
unittests-Instrumentation.Http 71.27% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 66.44% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-Resources.Gcp 39.60% <ø> (?)
unittests-Resources.Process 19.67% <ø> (?)
unittests-Resources.ProcessRuntime 82.35% <0.00%> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Resources.ProcessRuntime/ProcessRuntimeDetector.cs 93.33% <ø> (ø)
...Runtime/ProcessRuntimeResourceBuilderExtensions.cs 0.00% <0.00%> (ø)

... and 275 files with indirect coverage changes

# Conflicts:
#	.github/ISSUE_TEMPLATE/bug_report.yml
#	.github/ISSUE_TEMPLATE/feature_request.yml
#	.github/workflows/ci.yml
#	opentelemetry-dotnet-contrib.sln
@rajkumar-rangaraj
Copy link
Contributor

Require update to usage section in Readme, it still uses the old way of enablement which will not work -

var tracerProvider = Sdk.CreateTracerProviderBuilder()

@Kielek Kielek added the comp:resources.processruntime Things related to OpenTelemetry.Resources.ProcessRuntime label May 15, 2024
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (+ nit about the order), could you please resolve conflicts with main - you previous PR?

.github/component_owners.yml Show resolved Hide resolved
@CodeBlanch CodeBlanch merged commit e2c1e71 into open-telemetry:main May 16, 2024
160 of 161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.processruntime Things related to OpenTelemetry.Resources.ProcessRuntime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants