Rename OpenTelemetry.Extensions.Docker to OpenTelemetry.ResourceDetector.Container #881
Conversation
Kielek
added
the
comp:resources.container
|
@iskiselev could you please chek? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
+ Coverage 79.07% 79.48% +0.41%
==========================================
Files 182 182
Lines 5614 5629 +15
==========================================
+ Hits 4439 4474 +35
+ Misses 1175 1155 -20
|
|
Looks good to me. Thank you, @Kielek. I've raised small concern regards including ResourceDetector in this package name in #869. Let's confirm that we really want include it for this package (changing it from hosting-technology helper to only be resource detector) in the issue before merge. |
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Extensions.Docker", "src\OpenTelemetry.Extensions.Docker\OpenTelemetry.Extensions.Docker.csproj", "{498A6808-C0DF-441F-A764-51A3BC4B8FC5}" | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.ResourceDetector.Container", "src\OpenTelemetry.ResourceDetector.Container\OpenTelemetry.ResourceDetector.Container.csproj", "{498A6808-C0DF-441F-A764-51A3BC4B8FC5}" |
There was a problem hiding this comment.
@Kielek @iskiselev We discussed this name change in the SIG meeting yesterday (1/10).
While we're pretty confident this is a better name for this package, I'd like to hold on merging it for just a bit.
I'm compiling a list of packages whose names I believe should also change. I'd like to go through that exercise first before making a final decision on this package. I'd hate to change this package only to decide later we want to change it again.
Question: What do the two of you think about releasing the package once more under the old name OpenTelemetry.Extensions.Docker so we can get the work from #839 released independent of the name change?
There was a problem hiding this comment.
There was a problem hiding this comment.
@alanwest , It is fine for me to release it without renaming.
If you want to wait a bit longer (more than a week o two), I would consider to close the PR for now and reopen when needed. Feel free to do it if you agree.
* Changes Update CHANGELOG for 1.1.0-beta.1 release, that will include CGroup V2 support (open-telemetry#839, open-telemetry#693). It still have `-beta.1` suffix to make it prerelease until decision on package name will be done (open-telemetry#881, open-telemetry#869)
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #869.
Changes
Rename OpenTelemetry.Extensions.Docker to OpenTelemetry.ResourceDetector.Container.
Label in repository changed from
comp:extensions.dockertocomp:resourcedetector.containerFrom changelog
Going forward the NuGet package will be
OpenTelemetry.ResourceDetector.Container.Older versions will remain at
OpenTelemetry.Extensions.Docker(#881)
Migration:
using OpenTelemetry.Extensions.Docker.Resources->using OpenTelemetry.ResourceDetector.Container)and the class name (
DockerResourceDetectortoContainerResourceDetector).For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes