Add SetVerboseDatabaseStatements and Enrich options to the Redis instrumentation #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2198 +/- ##
==========================================
- Coverage 80.87% 80.17% -0.71%
==========================================
Files 226 226
Lines 7096 7161 +65
==========================================
+ Hits 5739 5741 +2
- Misses 1357 1420 +63
|
CodeBlanch
reviewed
Aug 4, 2021
...y.Instrumentation.StackExchangeRedis/OpenTelemetry.Instrumentation.StackExchangeRedis.csproj
Outdated
Show resolved
Hide resolved
ejsmith
changed the title
CodeBlanch
reviewed
Aug 6, 2021
src/OpenTelemetry.Instrumentation.StackExchangeRedis/.publicApi/net461/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
|
@CodeBlanch have you guys thought about moving this to the contrib project? |
cijothomas
reviewed
Aug 10, 2021
...elemetry.Instrumentation.StackExchangeRedis/StackExchangeRedisCallsInstrumentationOptions.cs
Show resolved
Hide resolved
cijothomas
reviewed
Aug 10, 2021
cijothomas
reviewed
Aug 10, 2021
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
|
Thanks @cijothomas @CodeBlanch ! |
|
When will this be released on NuGet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different take on adding keys to the Redis instrumentation similar to #1972. It puts it behind a new
SetVerboseDatabaseStatementsflag so that no performance penalty is incurred if the option isn't enabled. It also adds anEnrichoption like other instrumentations have. TheEnrichoption could technically be used to add theSetVerboseDatabaseStatementsfunctionality, but it seems like it's nice to have that ability built into the instrumentation.