New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Add-labels workflow fix #5605
[repo] Add-labels workflow fix #5605
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5605 +/- ##
==========================================
+ Coverage 83.38% 85.74% +2.35%
==========================================
Files 297 254 -43
Lines 12531 10985 -1546
==========================================
- Hits 10449 9419 -1030
+ Misses 2082 1566 -516
Flags with carried forward coverage won't be shown. Click here to find out more. |
.github/workflows/add-labels.yml
Outdated
$match = [regex]::Match('${{ github.event.issue.body }}', '^[#]+ Area\s*?(area:\w+)') | ||
$body = | ||
@" | ||
${{ github.event.issue.body }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be a script injection concern? For example if the user put something like "@
in the issue description? This bring a general concern regarding how are script injection are handled in other CI flows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes ya you are right. I updated it so it doesn't inject anything into the script content.
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Just thinking, should we make a dropdown for "signal" (tracing/logs/metrics/other?) on the bug template and also add a label for that? |
I guess this would be useful to the user for the feature request template, maybe start from there and see how things work, and if went well, come back to the bug template. |
Follow-up to #5601
Changes
add-labels.yml
workflow so that the powershell properly handles issue body text containing newlines (see: https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/9033019307/job/24822395367)Merge requirement checklist