Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Add-labels workflow fix #5605

Merged

Conversation

CodeBlanch
Copy link
Member

Follow-up to #5601

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label May 10, 2024
@CodeBlanch CodeBlanch requested a review from a team as a code owner May 10, 2024 18:48
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.74%. Comparing base (6250307) to head (833337b).
Report is 216 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5605      +/-   ##
==========================================
+ Coverage   83.38%   85.74%   +2.35%     
==========================================
  Files         297      254      -43     
  Lines       12531    10985    -1546     
==========================================
- Hits        10449     9419    -1030     
+ Misses       2082     1566     -516     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.72% <ø> (?)
unittests-Solution-Stable 85.40% <ø> (?)
unittests-Unstable-Core 19.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 112 files with indirect coverage changes

$match = [regex]::Match('${{ github.event.issue.body }}', '^[#]+ Area\s*?(area:\w+)')
$body =
@"
${{ github.event.issue.body }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a script injection concern? For example if the user put something like "@ in the issue description? This bring a general concern regarding how are script injection are handled in other CI flows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes ya you are right. I updated it so it doesn't inject anything into the script content.

Co-authored-by: Reiley Yang <reyang@microsoft.com>
@CodeBlanch CodeBlanch merged commit 409d96d into open-telemetry:main May 10, 2024
43 checks passed
@CodeBlanch CodeBlanch deleted the repo-add-labels-workflow-fix branch May 10, 2024 20:11
@CodeBlanch
Copy link
Member Author

Just thinking, should we make a dropdown for "signal" (tracing/logs/metrics/other?) on the bug template and also add a label for that?

@reyang
Copy link
Member

reyang commented May 10, 2024

Just thinking, should we make a dropdown for "signal" (tracing/logs/metrics/other?) on the bug template and also add a label for that?

I guess this would be useful to the user for the feature request template, maybe start from there and see how things work, and if went well, come back to the bug template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants