Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-build-tools to v0.1.0 #2839

Closed
wants to merge 3 commits into from

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@Aneurysm9 Aneurysm9 added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 7, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #2839 (a3c8e83) into main (f86225b) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2839   +/-   ##
=====================================
  Coverage   69.3%   69.3%           
=====================================
  Files        145     145           
  Lines       6729    6729           
=====================================
+ Hits        4664    4667    +3     
+ Misses      1950    1948    -2     
+ Partials     115     114    -1     
Impacted Files Coverage Δ
samplers/jaegerremote/sampler_remote.go 87.4% <0.0%> (+1.9%) ⬆️

Comment on lines -157 to +156
github.com/spf13/viper v1.12.0 // indirect
github.com/spf13/viper v1.13.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the culprit. We can add a replace back to v1.12.0 until golangci-lint fixes this behavior.

@MadVikingGod
Copy link
Contributor

A summary for anyone interested.

  • Viper v1.13.0 changed so that all keys of nested maps will be transformed to lowercase. This was the intended behavior; they consider this a bug fix and won't change the behavior.
  • golangci-lint and multimod use viper; if either is upgraded to v1.13.0 they will break our current config.
  • golangci-lint marshals the yaml in .golangci.yaml to generate the config passed to linters. Specifically, revive.
  • revive doesn't use viper and looks for the specific argument string.
  • So the net effect is what was a golangci config for two particular linters in revive used a map[] for their arguments and are now seeing these panics with golangci-lint v1.15.0 because of the viper change. We use one of them.

I think our options are:

  1. Use a replace for viper v1.12.0 until this is ironed out upstream
  2. Disable the context-as-argument linter until this is sorted upstream.

@bogdandrutu
Copy link
Member Author

@MadVikingGod do you want me to add the replace?

@MrAlias
Copy link
Contributor

MrAlias commented Oct 20, 2022

Looks like viper does not have a plan to fix the issue: spf13/viper#1431

@MadVikingGod
Copy link
Contributor

The community agreed that disabling the linter, for the time being, is the better option. #2878 is the fix specifically for that. This can merge after.

@pellared
Copy link
Member

This PR is outdated.

@pellared pellared closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants