otelgrpc: Remove withoutContext #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrbs
changed the title
carrbs
changed the title
carrbs
requested review from
dashpole,
hanyuancheung and
a team
as code owners
pellared
added
the
Skip Changelog
pellared
approved these changes
Jan 2, 2024
MadVikingGod
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4705 +/- ##
=====================================
Coverage 81.2% 81.3%
=====================================
Files 150 150
Lines 10900 10885 -15
=====================================
- Hits 8858 8853 -5
+ Misses 1882 1873 -9
+ Partials 160 159 -1
|
MrAlias
reviewed
Jan 17, 2024
dashpole
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4703
Now that open-telemetry/opentelemetry-go#4671 is merged, the withoutCancel in otelgrpc is no longer needed.
DO NOT MERGE: This issue awaits a new release of OTel Go SDK where the mentioned PR will be included.Note From: @MadVikingGod I updated this to point to the new SDK that has the needed features.