-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelzap: Basic implementation of Core.Write #5539
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5539 +/- ##
=======================================
+ Coverage 63.1% 63.2% +0.1%
=======================================
Files 193 193
Lines 11892 11917 +25
=======================================
+ Hits 7504 7534 +30
+ Misses 4171 4166 -5
Partials 217 217
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change this PR so that it just partially implements Write
? Can you remove the code related to Enabled
, Check
, With
?
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Core
Core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Thanks @khushijain21 👍 |
Part of #5191
Pre-work #5279
This PR implements
Write
method for Core