Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for end-to-end tracing on AWS Lambda #882

Closed
wants to merge 35 commits into from

Conversation

garrettwegan
Copy link
Contributor

@garrettwegan garrettwegan commented Jul 13, 2021

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 13, 2021

CLA Signed

The committers are authorized under a signed CLA.

@garrettwegan garrettwegan marked this pull request as draft July 13, 2021 20:29
@garrettwegan garrettwegan changed the title DRAFT - Add support for end-to-end tracing on AWS Lambda Add support for end-to-end tracing on AWS Lambda Jul 20, 2021
@garrettwegan garrettwegan marked this pull request as ready for review July 20, 2021 20:44
@MrAlias MrAlias added the blocked: CLA Waiting on CLA to be signed before progress can be made label Jul 22, 2021
Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both modules require README.md describing their use and the instrumentation should have an example. See other instrumentation for samples.

detectors/aws/lambda/detector.go Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 dismissed their stale review July 28, 2021 19:58

My remaining comments are aesthetic/conventional and not structural.

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #882 (e2a18cc) into main (d65eb72) will increase coverage by 0.9%.
The diff coverage is 93.1%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #882     +/-   ##
=======================================
+ Coverage   75.7%   76.6%   +0.9%     
=======================================
  Files         70      75      +5     
  Lines       4467    4685    +218     
=======================================
+ Hits        3382    3592    +210     
- Misses       943     946      +3     
- Partials     142     147      +5     
Impacted Files Coverage Δ
.../github.com/aws/aws-lambda-go/otellambda/lambda.go 88.6% <88.6%> (ø)
.../aws/aws-lambda-go/otellambda/wrapLambdaHandler.go 92.0% <92.0%> (ø)
detectors/aws/lambda/detector.go 100.0% <100.0%> (ø)
.../github.com/aws/aws-lambda-go/otellambda/config.go 100.0% <100.0%> (ø)
...ub.com/aws/aws-lambda-go/otellambda/wrapHandler.go 100.0% <100.0%> (ø)
... and 1 more

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the AWS X-Ray team, generally lgtm, just a couple questions!

@willarmiros
Copy link
Contributor

@bhautikpip would you mind taking a quick look from AWS side as well?

@open-telemetry/go-approvers would anyone else also be able to give this a look and get it merged? Many of the files changed are examples/documentation, and we would love to release this to OTel Go users!

@garrettwegan
Copy link
Contributor Author

@jmacd and @MrAlias I think both of y'all checked out the links to my PR's in the SIG last week, if either of y'all have had a chance to look them over a bit I'd love some feedback

Copy link
Contributor

@bhautikpip bhautikpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@garrettwegan
Copy link
Contributor Author

Closing in favor of #983, @bhautikpip will own related PRs going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants