indicate invalid slice if we couldn't turn them into json

open-telemetry · Apr 8, 2024 · 338edfc · 338edfc
1 parent 3551d56
commit 338edfc
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/attribute/value.go b/attribute/value.go
@@ -231,17 +231,26 @@ func (v Value) Emit() string {
 	case BOOL:
 		return strconv.FormatBool(v.AsBool())
 	case INT64SLICE:
-		j, _ := json.Marshal(v.asInt64Slice())
+		j, err := json.Marshal(v.asInt64Slice())
+		if err != nil {
+			return fmt.Sprintf("invalid: %v", v.asInt64Slice())
+		}
 		return string(j)
 	case INT64:
 		return strconv.FormatInt(v.AsInt64(), 10)
 	case FLOAT64SLICE:
-		j, _ := json.Marshal(v.asFloat64Slice())
+		j, err := json.Marshal(v.asFloat64Slice())
+		if err != nil {
+			return fmt.Sprintf("invalid: %v", v.asFloat64Slice())
+		}
 		return string(j)
 	case FLOAT64:
 		return fmt.Sprint(v.AsFloat64())
 	case STRINGSLICE:
-		j, _ := json.Marshal(v.asStringSlice())
+		j, err := json.Marshal(v.asStringSlice())
+		if err != nil {
+			return fmt.Sprintf("invalid: %v", v.asStringSlice())
+		}
 		return string(j)
 	case STRING:
 		return v.stringly