Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix histogram instrument unit test #2442

Closed
hanyuancheung opened this issue Dec 10, 2021 · 0 comments · Fixed by #2716
Closed

Fix histogram instrument unit test #2442

hanyuancheung opened this issue Dec 10, 2021 · 0 comments · Fixed by #2716
Assignees
@XSAM
Labels
bug Something isn't working
Projects
Bugs
Milestone
Release v1.7.0

Comments

@hanyuancheung
Copy link
Member

Description

Following discussion: #2423 (comment)

The exporter should still be able to test these histogram instrument kinds, after having removed MinMaxSumCount kind aggregation. But when keeping histogram instrument test, there's something went wrong, so we should fix the test case.

Steps To Reproduce

Run make test with keeping 'test-int64-histogram' and 'test-float64-histogram'.

Expected behavior

Exporter still be able to test histogram instrument kinds.
@hanyuancheung hanyuancheung added the bug Something isn't working label Dec 10, 2021
@MrAlias MrAlias added this to Needs triage in Bugs via automation Dec 10, 2021
@MrAlias MrAlias moved this from Needs triage to Low priority in Bugs Dec 10, 2021
@hanyuancheung hanyuancheung mentioned this issue Dec 13, 2021
Closed
6 tasks
@XSAM XSAM moved this from Low priority to High priority in Bugs Jan 5, 2022
@XSAM XSAM moved this from High priority to Low priority in Bugs Jan 5, 2022
@XSAM XSAM self-assigned this Jan 6, 2022
@Jacob953 Jacob953 mentioned this issue Jan 12, 2022
Merged
1 task
@XSAM XSAM mentioned this issue Mar 22, 2022
Merged
Bugs automation moved this from Low priority to Closed Apr 14, 2022
@MrAlias MrAlias added this to the Release v1.7.0 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XSAM XSAM

Labels
bug Something isn't working
Projects
Go: Bugs
Archived in project
Bugs
  
Closed
Milestone
Release v1.7.0
Development

Successfully merging a pull request may close this issue.

Fix histogram e2e test XSAM/opentelemetry-go
3 participants
@MrAlias @XSAM @hanyuancheung