Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histogram e2e test #2716

Merged
merged 9 commits into from Apr 14, 2022
Merged

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Mar 22, 2022

Closes: #2442

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #2716 (b884aca) into main (46a10bb) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2716     +/-   ##
=======================================
- Coverage   75.8%   75.7%   -0.1%     
=======================================
  Files        178     178             
  Lines      11707   11703      -4     
=======================================
- Hits        8875    8868      -7     
- Misses      2607    2610      +3     
  Partials     225     225             
Impacted Files Coverage Δ
...tlp/otlpmetric/internal/otlpmetrictest/otlptest.go 0.0% <0.0%> (ø)
internal/global/state.go 100.0% <ø> (ø)
trace.go 66.6% <0.0%> (-33.4%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 22, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Mar 31, 2022

Looks like the update broke the tests. @XSAM is this something you can look into?

@XSAM
Copy link
Member Author

XSAM commented Apr 2, 2022

I have fixed the tests, but I have no idea why codecov/patch fails.

@MrAlias MrAlias merged commit 6729811 into open-telemetry:main Apr 14, 2022
@XSAM XSAM deleted the fix-histogram-e2e-test branch April 15, 2022 00:57
@MrAlias MrAlias added this to the Release v1.7.0 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix histogram instrument unit test
4 participants