baggage.Members() returns members with hasData set to false

[lgfa29]

Description

NOTE: I'm not sure if this is actually a bug or working as intended, so feel free to close it.

When calling baggage.Members() the slice of Member returned has all elements with hasData set to false. This prevents them from being set in other baggages since baggage.SetMember() will fail.

Environment

• OS: macOS
• Architecture: x86
• Go Version: 1.19
• opentelemetry-go version: 1.9.0

Steps To Reproduce

Sample playground: https://go.dev/play/p/tJa5-fMVCk1

Expected behavior

Members returned by baggage.Members() can be used in other baggages.

[MrAlias]

This looks like something we failed to include in #2522

[lgfa29]

Thanks for the confirmation! I will try to get a PR with a fix soon 🙂

[MrAlias]

@lgfa29 it looks like @hanyuancheung has submitted #3165 to address this. Please take a look at that PR before starting work here.

[lgfa29]

@lgfa29 it looks like @hanyuancheung has submitted #3165 to address this. Please take a look at that PR before starting work here.

Oh awesome! I got sidetracked so I didn't have time to open the PR. That looks like the changes I was thinking of doing, so looks like I don't have to anymore 🙂

Thanks for the heads-up!