Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix baggage set member failed #3165

Merged
merged 6 commits into from Sep 17, 2022
Merged

bugfix: fix baggage set member failed #3165

merged 6 commits into from Sep 17, 2022

Conversation

hanyuancheung
Copy link
Member

Fix: #3164

@hanyuancheung hanyuancheung added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited

Codecov Report

Merging #3165 (5b3a64d) into main (e1a1f07) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3165     +/-   ##
=======================================
- Coverage   77.3%   77.3%   -0.1%     
=======================================
  Files        158     158             
  Lines      11082   11084      +2     
=======================================
  Hits        8577    8577             
- Misses      2308    2310      +2     
  Partials     197     197
Impacted Files Coverage Δ
baggage/baggage.go 97.3% <100.0%> (+<0.1%) ⬆️
sdk/trace/batch_span_processor.go 81.1% <0.0%> (-0.9%) ⬇️

MrAlias
MrAlias reviewed Sep 13, 2022
View reviewed changes
baggage/baggage_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias mentioned this pull request Sep 13, 2022
Closed
@hanyuancheung hanyuancheung force-pushed the feature/csuzhang_fix_baggage_set_member_failed branch 2 times, most recently from 99252c1 to a3ce943 Compare September 14, 2022 17:20
@MrAlias MrAlias added this to the Release v1.11.0 milestone Sep 15, 2022
@MrAlias MrAlias merged commit 30fcf78 into open-telemetry:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Release v1.11.0
Development

Successfully merging this pull request may close these issues.

baggage.Members() returns members with hasData set to false
3 participants
@hanyuancheung @MadVikingGod @MrAlias